Skip to content

Backport Close file on invalid range (Addition to #15166) (#15268) #15308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2021
Merged

Backport Close file on invalid range (Addition to #15166) (#15268) #15308

merged 3 commits into from
Apr 6, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 6, 2021

Backport of #15268

@KN4CK3R @zeripath
@lafriks @lunny
Close file on invalid range (Addition to go-gitea#15166) (go-gitea#15268
6430e66 
)

* Close file on invalid range.

* Close on seek error

Signed-off-by: Andrew Thornton <[email protected]>

* Moved 'Seek' into server.

* io.ReadSeekCloser is only available in Go 1.16

Co-authored-by: Andrew Thornton <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 6, 2021
@zeripath zeripath added this to the 1.14.0 milestone Apr 6, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit cf9b6c2 into go-gitea:release/v1.14 Apr 6, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 9, 2021
@KN4CK3R KN4CK3R deleted the backport-15268 branch May 7, 2021 06:33
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@KN4CK3R @techknowlogick @lunny @zeripath @GiteaBot @6543